Skip to content

HADOOP-17569. Building native code fails on Fedora 33.#2886

Merged
iwasakims merged 1 commit intoapache:trunkfrom
iwasakims:HADOOP-17569
Apr 15, 2021
Merged

HADOOP-17569. Building native code fails on Fedora 33.#2886
iwasakims merged 1 commit intoapache:trunkfrom
iwasakims:HADOOP-17569

Conversation

@iwasakims
Copy link
Member

@iwasakims iwasakims commented Apr 9, 2021

https://issues.apache.org/jira/browse/HADOOP-17569

strerror of glibc >= 2.32 is thread safe. We can just use it. We still need existing code for supporting old glibc.
https://sourceware.org/pipermail/libc-announce/2020/000029.html

  • The deprecated symbols sys_errlist, _sys_errlist, sys_nerr, and _sys_nerr
    are no longer available to newly linked binaries, and their declarations
    have been removed from from <stdio.h>. They are exported solely as
    compatibility symbols to support old binaries. All programs should use
    strerror or strerror_r instead.

  • Both strerror and strerror_l now share the same internal buffer in the
    calling thread, meaning that the returned string pointer may be invalided
    or contents might be overwritten on subsequent calls in the same thread or
    if the thread is terminated. It makes strerror MT-safe.

In addition, I added -fcommon to CFLAGS for building code of hadoop-hdfs-native-client since -fno-common (default from GCC 10.0) break the build.
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85678

@iwasakims
Copy link
Member Author

iwasakims commented Apr 9, 2021

-Pnative build succeeded on Fedora 33 (bundling glibc-2.32) and CentOS 8 (bundling glibc-2.28).

@hadoop-yetus
Copy link

hadoop-yetus commented Apr 9, 2021

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 55s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 1s codespell was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+0 🆗 mvndep 15m 10s Maven dependency ordering for branch
+1 💚 mvninstall 22m 56s trunk passed
+1 💚 compile 22m 24s trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚 compile 19m 51s trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚 mvnsite 2m 1s trunk passed
+1 💚 shadedclient 98m 27s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 24s Maven dependency ordering for patch
+1 💚 mvninstall 1m 14s the patch passed
+1 💚 compile 26m 23s the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
-1 ❌ cc 26m 23s /results-compile-cc-root-jdkUbuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04.txt root-jdkUbuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 generated 28 new + 299 unchanged - 28 fixed = 327 total (was 327)
+1 💚 golang 26m 23s the patch passed
+1 💚 javac 26m 23s the patch passed
+1 💚 compile 23m 50s the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
-1 ❌ cc 23m 50s /results-compile-cc-root-jdkPrivateBuild-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08.txt root-jdkPrivateBuild-1.8.0_282-8u282-b08-0ubuntu120.04-b08 with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu120.04-b08 generated 23 new + 304 unchanged - 23 fixed = 327 total (was 327)
+1 💚 golang 23m 50s the patch passed
+1 💚 javac 23m 50s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 mvnsite 2m 17s the patch passed
+1 💚 shadedclient 21m 24s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 19m 21s hadoop-common in the patch passed.
+1 💚 unit 109m 22s hadoop-hdfs-native-client in the patch passed.
+1 💚 asflicense 0m 53s The patch does not generate ASF License warnings.
304m 10s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2886/1/artifact/out/Dockerfile
GITHUB PR #2886
Optional Tests dupname asflicense compile cc mvnsite javac unit codespell golang
uname Linux 94a19cda21ab 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 551c614
Default Java Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2886/1/testReport/
Max. process+thread count 1252 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-native-client U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2886/1/console
versions git=2.25.1 maven=3.6.3
Powered by Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@iwasakims
Copy link
Member Author

iwasakims commented Apr 12, 2021

root-jdkPrivateBuild-1.8.0_282-8u282-b08-0ubuntu120.04-b08 with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu120.04-b08 generated 23 new + 304 unchanged - 23 fixed = 327 total (was 327)

cc warnings are not related to the patch.

aajisaka
aajisaka approved these changes Apr 15, 2021
View reviewed changes
Copy link
Member

@aajisaka aajisaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you @iwasakims

@iwasakims iwasakims merged commit 2717203 into apache:trunk Apr 15, 2021
@iwasakims
Copy link
Member Author

iwasakims commented Apr 15, 2021

Thanks, @aajisaka. I merged this.

iwasakims added a commit that referenced this pull request Apr 15, 2021
@iwasakims
HADOOP-17569. Building native code fails on Fedora 33. (#2886)
a3405cb 
(cherry picked from commit 2717203)
iwasakims added a commit that referenced this pull request Apr 15, 2021
@iwasakims
HADOOP-17569. Building native code fails on Fedora 33. (#2886)
08cc11c 
(cherry picked from commit 2717203)
charles1614 pushed a commit to charles1614/hadoop that referenced this pull request Nov 8, 2021
@iwasakims @charles1614
HADOOP-17569. Building native code fails on Fedora 33. (apache#2886)
184db91
kiran-maturi pushed a commit to kiran-maturi/hadoop that referenced this pull request Nov 24, 2021
@iwasakims
HADOOP-17569. Building native code fails on Fedora 33. (apache#2886)
b37d613
iwasakims added a commit that referenced this pull request Jul 5, 2022
@iwasakims
HADOOP-17569. Building native code fails on Fedora 33. (#2886)
6ca9581 
(cherry picked from commit 2717203)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aajisaka aajisaka aajisaka approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@iwasakims @hadoop-yetus @aajisaka